Racer 2 #629
Merged
Racer 2 #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigbeck
commented
Apr 19, 2024
| const Racer = require('racer/lib/Racer'); | ||
|
|
||
| export abstract class DerbyBase extends Racer { | ||
| export abstract class Derby extends Racer { |
There was a problem hiding this comment.
Only for EventEmitter?
There was a problem hiding this comment.
Also racer's use and serverUse, might be used for other things too
There was a problem hiding this comment.
yes, also exposing the util functions
ericyhwang
reviewed
Apr 23, 2024
| const Racer = require('racer/lib/Racer'); | ||
|
|
||
| export abstract class DerbyBase extends Racer { | ||
| export abstract class Derby extends Racer { |
There was a problem hiding this comment.
Also racer's use and serverUse, might be used for other things too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentClass.prototype.singleton = true;is no longer supported.class ComponentClass { static singleton = true; }ComponentClass.singleton = true;Derbybase,DerbyForClientandDerbyForServersubclassesPagebase,PageForClientandPageForServersubclassesAppbase,AppForClientandAppForServersubclassesrender()method between client and server has consistent arg ordering (previously reversed between client and server)